◐ Shell
clean mode source ↗

src: fix dynamically linked zlib version by richardlau · Pull Request #51007 · nodejs/node

nodejs-github-bot

Report the version of the dynamically linked zlib if built with
`configure --shared-zlib` instead of the hardcoded version that
corresponds to the bundled version of zlib in `deps`.

@nodejs-github-bot added build

Issues and PRs related to build files or the CI.

c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

labels

Dec 1, 2023

@richardlau richardlau added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Dec 3, 2023

mhdawson

@richardlau richardlau added commit-queue

Add this label to land a pull request using GitHub Actions.

and removed request-ci

Add this label to start a Jenkins CI on a PR.

labels

Dec 4, 2023

RafaelGSS pushed a commit that referenced this pull request

Dec 15, 2023 
Report the version of the dynamically linked zlib if built with
`configure --shared-zlib` instead of the hardcoded version that
corresponds to the bundled version of zlib in `deps`.

PR-URL: #51007
Refs: #50910
Refs: #50158
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

richardlau added a commit that referenced this pull request

Mar 25, 2024 
Report the version of the dynamically linked zlib if built with
`configure --shared-zlib` instead of the hardcoded version that
corresponds to the bundled version of zlib in `deps`.

PR-URL: #51007
Refs: #50910
Refs: #50158
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

This was referenced

Jun 12, 2024