◐ Shell
clean mode source ↗

test_runner: add support for null and date value output by malthe · Pull Request #51920 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added needs-ci

PRs that need a full CI run.

test_runner

Issues and PRs related to the test runner subsystem.

labels

Feb 29, 2024

@malthe

aduh95

aduh95

This fixes an issue where a value could be `instanceof Date` without actually being a native date.

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

atlowChemi

benjamingr

@aduh95 aduh95 added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Mar 1, 2024

@aduh95 aduh95 added commit-queue

Add this label to land a pull request using GitHub Actions.

commit-queue-squash

Add this label to instruct the Commit Queue to squash all the PR commits into the first one.

and removed commit-queue-failed

An error occurred while landing this pull request using GitHub Actions.

labels

Mar 2, 2024

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request

Mar 26, 2024 
PR-URL: nodejs#51920
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

May 2, 2024 
PR-URL: #51920
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>