◐ Shell
clean mode source ↗

esm: drop support for import assertions by nicolo-ribaudo · Pull Request #52104 · nodejs/node

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

labels

Mar 15, 2024

nicolo-ribaudo

This patch removes support for the `assert` keyword
for import attributes. It was an old variant of the
proposal that was only shipped in V8 and no other
engine, and that has then been replaced by the `with`
keyword.

Chrome is planning to remove support for `assert`
in version 126, which will be released in June.

Node.js already supports the `with` keyword for
import attributes, and this patch does not change that.

mcollina

joyeecheung

valadaptive added a commit to valadaptive/scratchblocks that referenced this pull request

Jun 16, 2024
These no longer build in Node 22 since import assertions were removed:
nodejs/node#52104

KockaAdmiralac pushed a commit to WikiaUsers/ContentReviewLog that referenced this pull request

Jul 5, 2024
* fix syntax error due to `assert`

nodejs/node#52104 (comment)

* fix missed assert

thanks for pointing it out puxlit

* bump nodejs version and regenerate package-lock.json per kocka's request

@evert evert mentioned this pull request

Aug 8, 2024

nodejs-github-bot pushed a commit that referenced this pull request

Nov 18, 2024
PR-URL: #55883
Refs: #52104
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

tpoisseau pushed a commit to tpoisseau/node that referenced this pull request

Nov 21, 2024
PR-URL: nodejs#55883
Refs: nodejs#52104
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Nov 26, 2024
PR-URL: nodejs#55883
Refs: nodejs#52104
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

aduh95 added a commit that referenced this pull request

Nov 26, 2024
PR-URL: #55883
Refs: #52104
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

aduh95 added a commit that referenced this pull request

Dec 10, 2024
PR-URL: #55883
Refs: #52104
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

buzz added a commit to buzz/imdb-link-em-all that referenced this pull request

Dec 17, 2024

ruyadorno pushed a commit that referenced this pull request

Jan 5, 2025
PR-URL: #55883
Refs: #52104
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

@jpmcb jpmcb mentioned this pull request

May 2, 2025

@eucyt eucyt mentioned this pull request

May 7, 2025