test: mitigate flaky test-debug-no-context by Trott · Pull Request #5269 · nodejs/node
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: nodejs#5268 Fixes: nodejs#4343
labels
Trott added a commit to Trott/io.js that referenced this pull request
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: nodejs#5268 Fixes: nodejs#4343 PR-URL: nodejs#5269 Reviewed-By: James M Snell <jasnell@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request
test-debug-no-context flakiness was worked around in issue 5269 but the flaky designation was left for the test. This change removes it. Refs: nodejs#5269
jasnell pushed a commit that referenced this pull request
rvagg pushed a commit that referenced this pull request
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: #5268 Fixes: #4343 PR-URL: #5269 Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request
MylesBorins pushed a commit that referenced this pull request
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: #5268 Fixes: #4343 PR-URL: #5269 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request
MylesBorins pushed a commit that referenced this pull request
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: #5268 Fixes: #4343 PR-URL: #5269 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request
MylesBorins pushed a commit that referenced this pull request
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: #5268 Fixes: #4343 PR-URL: #5269 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request