◐ Shell
clean mode source ↗

test_runner: fix t.assert methods by cjihrig · Pull Request #53049 · nodejs/node

nodejs-github-bot

The node:assert module contains several top level APIs that do
not make sense to expose as methods on t.assert. Examples include
AssertionError and CallTracker. This commit removes such APIs from
t.assert.

Refs: nodejs#52860

@nodejs-github-bot added needs-ci

PRs that need a full CI run.

test_runner

Issues and PRs related to the test runner subsystem.

labels

May 18, 2024

aduh95

benjamingr

atlowChemi

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

@cjihrig cjihrig added the commit-queue-squash

Add this label to instruct the Commit Queue to squash all the PR commits into the first one.

label

May 19, 2024

atlowChemi

aduh95

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

atlowChemi

@MoLow MoLow added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

May 20, 2024

@cjihrig cjihrig added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

and removed needs-ci

PRs that need a full CI run.

labels

May 20, 2024

targos pushed a commit that referenced this pull request

May 21, 2024 
The node:assert module contains several top level APIs that do
not make sense to expose as methods on t.assert. Examples include
AssertionError and CallTracker. This commit removes such APIs from
t.assert.

Refs: #52860
PR-URL: #53049
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

soophoo pushed a commit to soophoo/node that referenced this pull request

Jun 20, 2024 
The node:assert module contains several top level APIs that do
not make sense to expose as methods on t.assert. Examples include
AssertionError and CallTracker. This commit removes such APIs from
t.assert.

Refs: nodejs#52860
PR-URL: nodejs#53049
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

bmeck pushed a commit to bmeck/node that referenced this pull request

Jun 22, 2024 
The node:assert module contains several top level APIs that do
not make sense to expose as methods on t.assert. Examples include
AssertionError and CallTracker. This commit removes such APIs from
t.assert.

Refs: nodejs#52860
PR-URL: nodejs#53049
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Jul 19, 2024 
The node:assert module contains several top level APIs that do
not make sense to expose as methods on t.assert. Examples include
AssertionError and CallTracker. This commit removes such APIs from
t.assert.

Refs: #52860
PR-URL: #53049
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Jul 19, 2024 
The node:assert module contains several top level APIs that do
not make sense to expose as methods on t.assert. Examples include
AssertionError and CallTracker. This commit removes such APIs from
t.assert.

Refs: #52860
PR-URL: #53049
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>