◐ Shell
clean mode source ↗

crypto: remove CipherBase::Init by tniessen · Pull Request #57787 · nodejs/node

tniessen

As far as I can tell, the `iv` parameter can never be `undefined` (but
it can be `null`!), so this code appears to have been dead since
Node.js 22.

This change removes dead code and adds a tiny test case for passing
`undefined` as the IV.

Refs: nodejs#50973

@nodejs-github-bot nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs related to general changes in the lib or src directory.

needs-ci

PRs that need a full CI run.

labels

Apr 7, 2025

@tniessen tniessen added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 7, 2025

@aduh95 aduh95 added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Apr 9, 2025

JonasBa pushed a commit to JonasBa/node that referenced this pull request

Apr 11, 2025 
As far as I can tell, the `iv` parameter can never be `undefined` (but
it can be `null`!), so this code appears to have been dead since
Node.js 22.

This change removes dead code and adds a tiny test case for passing
`undefined` as the IV.

Refs: nodejs#50973
PR-URL: nodejs#57787
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>

RafaelGSS pushed a commit that referenced this pull request

May 1, 2025 
As far as I can tell, the `iv` parameter can never be `undefined` (but
it can be `null`!), so this code appears to have been dead since
Node.js 22.

This change removes dead code and adds a tiny test case for passing
`undefined` as the IV.

Refs: #50973
PR-URL: #57787
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>

RafaelGSS pushed a commit that referenced this pull request

May 2, 2025 
As far as I can tell, the `iv` parameter can never be `undefined` (but
it can be `null`!), so this code appears to have been dead since
Node.js 22.

This change removes dead code and adds a tiny test case for passing
`undefined` as the IV.

Refs: #50973
PR-URL: #57787
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>