◐ Shell
clean mode source ↗

src: multiple updates to node locks by jasnell · Pull Request #60061 · nodejs/node

@nodejs-github-bot nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs related to general changes in the lib or src directory.

needs-ci

PRs that need a full CI run.

labels

Sep 28, 2025

@jasnell jasnell changed the title Jasnell/node locks dictionarytemplate src: multiple updates to node locks

Sep 28, 2025

addaleax

addaleax

...and other minor cleanups
* Track memory held by the Lock instance
* Clean up some Utf8/TwoByteString handling

addaleax

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Oct 6, 2025

nodejs-github-bot pushed a commit that referenced this pull request

Oct 11, 2025
...and other minor cleanups

PR-URL: #60061
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

nodejs-github-bot pushed a commit that referenced this pull request

Oct 11, 2025
* Track memory held by the Lock instance
* Clean up some Utf8/TwoByteString handling

PR-URL: #60061
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

Oct 31, 2025
...and other minor cleanups

PR-URL: #60061
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

Oct 31, 2025
* Track memory held by the Lock instance
* Clean up some Utf8/TwoByteString handling

PR-URL: #60061
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

Nov 7, 2025
...and other minor cleanups

PR-URL: #60061
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

Nov 7, 2025
* Track memory held by the Lock instance
* Clean up some Utf8/TwoByteString handling

PR-URL: #60061
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

jkleinsc added a commit to electron/electron that referenced this pull request

Nov 13, 2025

codebytere pushed a commit to electron/electron that referenced this pull request

Nov 14, 2025

jkleinsc added a commit to electron/electron that referenced this pull request

Nov 18, 2025
* chore: bump node in DEPS to v24.11.1

* src: add a default branch for module phase

nodejs/node#60261

* src: conditionally disable source phase imports by default

nodejs/node#60364

* chore: update patches

* src: update locks to use DictionaryTemplate and other minor cleanups

nodejs/node#60061

* deps: update simdjson to 4.0.7

nodejs/node#59883

* test: move sea tests into test/sea

nodejs/node#60250

* fixup deps: update simdjson to 4.0.7a

* src: conditionally disable source phase imports by default

nodejs/node#60364

* module: handle null source from async loader hooks in sync hooks

nodejs/node#59929

* Revert "src: conditionally disable source phase imports by default"

This reverts commit 5f85b84.

* src: allow disabling JS source phase imports

nodejs/node#60364

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

jkleinsc added a commit to electron/electron that referenced this pull request

Nov 18, 2025
* chore: bump node in DEPS to v24.11.1

* src: add a default branch for module phase

nodejs/node#60261

* src: conditionally disable source phase imports by default

nodejs/node#60364

* chore: update patches

* src: update locks to use DictionaryTemplate and other minor cleanups

nodejs/node#60061

* deps: update simdjson to 4.0.7

nodejs/node#59883

* test: move sea tests into test/sea

nodejs/node#60250

* fixup deps: update simdjson to 4.0.7a

* src: conditionally disable source phase imports by default

nodejs/node#60364

* module: handle null source from async loader hooks in sync hooks

nodejs/node#59929

* Revert "src: conditionally disable source phase imports by default"

This reverts commit 5f85b84.

* src: allow disabling JS source phase imports

nodejs/node#60364

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

jkleinsc added a commit to electron/electron that referenced this pull request

Nov 18, 2025
* chore: bump node in DEPS to v24.11.1

* src: add a default branch for module phase

nodejs/node#60261

* src: conditionally disable source phase imports by default

nodejs/node#60364

* chore: update patches

* src: update locks to use DictionaryTemplate and other minor cleanups

nodejs/node#60061

* deps: update simdjson to 4.0.7

nodejs/node#59883

* test: move sea tests into test/sea

nodejs/node#60250

* fixup deps: update simdjson to 4.0.7a

* src: conditionally disable source phase imports by default

nodejs/node#60364

* module: handle null source from async loader hooks in sync hooks

nodejs/node#59929

* Revert "src: conditionally disable source phase imports by default"

This reverts commit 5f85b84.

* src: allow disabling JS source phase imports

nodejs/node#60364

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

jkleinsc added a commit to electron/electron that referenced this pull request

Nov 18, 2025
* chore: bump node in DEPS to v24.11.1

* chore: bump node to v24.11.1 (main) (#48917)

* chore: bump node in DEPS to v24.11.1

* src: add a default branch for module phase

nodejs/node#60261

* src: conditionally disable source phase imports by default

nodejs/node#60364

* chore: update patches

* src: update locks to use DictionaryTemplate and other minor cleanups

nodejs/node#60061

* deps: update simdjson to 4.0.7

nodejs/node#59883

* test: move sea tests into test/sea

nodejs/node#60250

* fixup deps: update simdjson to 4.0.7a

* src: conditionally disable source phase imports by default

nodejs/node#60364

* module: handle null source from async loader hooks in sync hooks

nodejs/node#59929

* Revert "src: conditionally disable source phase imports by default"

This reverts commit 5f85b84.

* src: allow disabling JS source phase imports

nodejs/node#60364

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>