◐ Shell
clean mode source ↗

tools: dump config.gypi as json by legendecas · Pull Request #60794 · nodejs/node

nodejs-github-bot

This helps js2c processing the node.gypi correctly when a string
contains a quote.

@nodejs-github-bot added build

Issues and PRs related to build files or the CI.

needs-ci

PRs that need a full CI run.

tools

Issues and PRs related to the tools directory.

labels

Nov 20, 2025

richardlau

marco-ippolito

@aduh95 aduh95 added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Nov 22, 2025

targos pushed a commit that referenced this pull request

Nov 27, 2025 
This helps js2c processing the node.gypi correctly when a string
contains a quote.

PR-URL: #60794
Refs: #60703
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request

Jan 9, 2026 
This helps js2c processing the node.gypi correctly when a string
contains a quote.

PR-URL: #60794
Refs: #60703
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

RafaelGSS pushed a commit that referenced this pull request

Jan 13, 2026 
This helps js2c processing the node.gypi correctly when a string
contains a quote.

PR-URL: #60794
Refs: #60703
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request

Jan 19, 2026 
This helps js2c processing the node.gypi correctly when a string
contains a quote.

PR-URL: #60794
Refs: #60703
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

codebytere added a commit to electron/electron that referenced this pull request

Feb 11, 2026

codebytere added a commit to electron/electron that referenced this pull request

Feb 11, 2026

codebytere added a commit to electron/electron that referenced this pull request

Feb 11, 2026

codebytere added a commit to electron/electron that referenced this pull request

Feb 12, 2026

codebytere added a commit to electron/electron that referenced this pull request

Feb 12, 2026

codebytere added a commit to electron/electron that referenced this pull request

Feb 13, 2026 
* chore: bump node in DEPS to v24.13.1

* chore: fixup patches

refs:
* nodejs/node#60425
* nodejs/node#61270
* nodejs/node#61044

* fix: generate_config_gypi needs to generate valid JSON

nodejs/node#60794

* doc: align Buffer.concat documentation with behavior

nodejs/node#60405

* src: fix off-thread cert loading in bundled cert mode

nodejs/node#60764

* build: fix extraneous includes

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

codebytere added a commit to electron/electron that referenced this pull request

Feb 13, 2026

codebytere added a commit to electron/electron that referenced this pull request

Feb 13, 2026

codebytere added a commit to electron/electron that referenced this pull request

Feb 13, 2026 
* chore: bump node in DEPS to v24.13.1

* chore: fixup patches

refs:
* nodejs/node#60425
* nodejs/node#61270
* nodejs/node#61044

* fix: generate_config_gypi needs to generate valid JSON

nodejs/node#60794

* doc: align Buffer.concat documentation with behavior

nodejs/node#60405

* src: fix off-thread cert loading in bundled cert mode

nodejs/node#60764

* chore: fixup patch indices

* build: fix extraneous includes

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

codebytere added a commit to electron/electron that referenced this pull request

Feb 13, 2026 
* chore: bump node in DEPS to v24.13.1

* chore: fixup patches

refs:
* nodejs/node#60425
* nodejs/node#61270
* nodejs/node#61044

* fix: generate_config_gypi needs to generate valid JSON

nodejs/node#60794

* doc: align Buffer.concat documentation with behavior

nodejs/node#60405

* src: fix off-thread cert loading in bundled cert mode

nodejs/node#60764

* chore: fixup patch indices

* build: fix extraneous includes

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

aduh95 pushed a commit that referenced this pull request

Feb 17, 2026 
This helps js2c processing the node.gypi correctly when a string
contains a quote.

PR-URL: #60794
Refs: #60703
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request

Feb 19, 2026 
This helps js2c processing the node.gypi correctly when a string
contains a quote.

PR-URL: #60794
Refs: #60703
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request

Feb 21, 2026 
This helps js2c processing the node.gypi correctly when a string
contains a quote.

PR-URL: #60794
Refs: #60703
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request

Feb 23, 2026 
This helps js2c processing the node.gypi correctly when a string
contains a quote.

PR-URL: #60794
Refs: #60703
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

kycutler pushed a commit to kycutler/electron that referenced this pull request

Feb 26, 2026 
* chore: bump node in DEPS to v24.13.1

* chore: fixup patches

refs:
* nodejs/node#60425
* nodejs/node#61270
* nodejs/node#61044

* fix: generate_config_gypi needs to generate valid JSON

nodejs/node#60794

* doc: align Buffer.concat documentation with behavior

nodejs/node#60405

* src: fix off-thread cert loading in bundled cert mode

nodejs/node#60764

* build: fix extraneous includes

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

jkleinsc added a commit to electron/electron that referenced this pull request

Mar 9, 2026

codebytere added a commit to electron/electron that referenced this pull request

Mar 10, 2026 
* chore: bump node in DEPS to v22.22.1

* chore: update patches

* chore: fixup remove_obsolete_noarraybufferzerofillscope.patch

* deps: update simdjson to 4.2.4

 nodejs/node#61056

* fix: generate_config_gypi needs to generate valid JSON

https: //github.com/nodejs/node/pull/60794
(cherry picked from commit a1d06cd)
Co-Authored-By: Shelley Vohr <shelley.vohr@gmail.com>

* src: fix off-thread cert loading in bundled cert mode

nodejs/node#60764
(cherry picked from commit cb4deec)

This test fails on boringssl incompatibilities:
https://github.com/electron/electron/pull/49744/changes#r2799802487

Co-Authored-By: Shelley Vohr <shelley.vohr@gmail.com>

* test: move sea tests into test/sea

nodejs/node#60250
(cherry picked from commit 695929b)

* src: fix off-thread cert loading in bundled cert mode

nodejs/node#60764

The Node.js cli flag --use-bundled-ca is not supported in Electron

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>