◐ Shell
clean mode source ↗

test: enforce better never-settling-promise detection by aduh95 · Pull Request #60976 · nodejs/node

nodejs-github-bot

Tests should be explicit regarding whether a promise is expected to
settle, and the test should fail when the behavior does not meet
expectations.

@nodejs-github-bot added addons

Issues and PRs related to native addons.

async_hooks

Issues and PRs related to the async hooks subsystem.

esm

Issues and PRs related to the ECMAScript Modules implementation.

needs-ci

PRs that need a full CI run.

node-api

Issues and PRs related to the Node-API.

test

Issues and PRs related to the tests.

labels

Dec 6, 2025

@aduh95 aduh95 added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

Dec 6, 2025

ErickWendel

gurgunday

@aduh95 aduh95 added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Dec 10, 2025

@aduh95 aduh95 deleted the never-settling-then branch

December 11, 2025 08:22

aduh95 added a commit that referenced this pull request

Jan 9, 2026 
Tests should be explicit regarding whether a promise is expected to
settle, and the test should fail when the behavior does not meet
expectations.

PR-URL: #60976
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>

aduh95 added a commit that referenced this pull request

Jan 12, 2026 
Tests should be explicit regarding whether a promise is expected to
settle, and the test should fail when the behavior does not meet
expectations.

PR-URL: #60976
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>

aduh95 added a commit that referenced this pull request

Jan 20, 2026 
Tests should be explicit regarding whether a promise is expected to
settle, and the test should fail when the behavior does not meet
expectations.

PR-URL: #60976
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>

islandryu pushed a commit to islandryu/node that referenced this pull request

Jan 25, 2026 
Tests should be explicit regarding whether a promise is expected to
settle, and the test should fail when the behavior does not meet
expectations.

PR-URL: nodejs#60976
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request

Jan 27, 2026

aduh95 added a commit that referenced this pull request

Feb 10, 2026 
Tests should be explicit regarding whether a promise is expected to
settle, and the test should fail when the behavior does not meet
expectations.

PR-URL: #60976
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>

aduh95 added a commit that referenced this pull request

Feb 22, 2026 
Tests should be explicit regarding whether a promise is expected to
settle, and the test should fail when the behavior does not meet
expectations.

PR-URL: #60976
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>