repl: handle exceptions from async context after close by addaleax · Pull Request #62165 · nodejs/node

a9da9ff recently restructured async context handling
in the REPL source so that it no longer uses the domain module,
and instead performs its own async context tracking.

That change was not intended to be breaking, but it affected
behavior for uncaught exceptions thrown after the REPL was closed.
Those would now be treated as uncaught exceptions on the process
level, which is probably not intentional in most situations.

While it's understandably not great that we handle execptions
after closing the REPL instance, I am confident that it's
best to restore the previous behavior for now and add more
granular handling options separately and intentionally
in a (potentially semver-major) follow-up change.

Refs: nodejs#61227

added needs-ci

repl

labels

addaleax added fast-track

and removed repl

needs-ci

labels

addaleax deleted the repl-uncaught-after-close branch

aduh95 pushed a commit that referenced this pull request

a9da9ff recently restructured async context handling
in the REPL source so that it no longer uses the domain module,
and instead performs its own async context tracking.

That change was not intended to be breaking, but it affected
behavior for uncaught exceptions thrown after the REPL was closed.
Those would now be treated as uncaught exceptions on the process
level, which is probably not intentional in most situations.

While it's understandably not great that we handle execptions
after closing the REPL instance, I am confident that it's
best to restore the previous behavior for now and add more
granular handling options separately and intentionally
in a (potentially semver-major) follow-up change.

Refs: #61227
PR-URL: #62165
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>