repl: add customizable error handling by addaleax · Pull Request #62188 · nodejs/node
added
the
semver-minor
label
Whether or not an exception should be handled when it was thrown in the REPL's context but the REPL is already closed is something that will depend on the details of the specific REPL instance's use case. Adding this option lets the REPL's creator control the details of this behavior. This resolves a TODO recently added in bd3cba5.
addaleax
added
author ready
labels
aduh95 pushed a commit that referenced this pull request
Whether or not an exception should be handled when it was thrown in the REPL's context but the REPL is already closed is something that will depend on the details of the specific REPL instance's use case. Adding this option lets the REPL's creator control the details of this behavior. This resolves a TODO recently added in bd3cba5. PR-URL: #62188 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request
Whether or not an exception should be handled when it was thrown in the REPL's context but the REPL is already closed is something that will depend on the details of the specific REPL instance's use case. Adding this option lets the REPL's creator control the details of this behavior. This resolves a TODO recently added in bd3cba5. PR-URL: #62188 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
nodejs-github-bot added a commit that referenced this pull request
Notable changes: async_hooks: * (SEMVER-MINOR) add using scopes to AsyncLocalStorage (Stephen Belanger) #61674 benchmark: * (SEMVER-MINOR) add benchmarks for experimental stream/iter (James M Snell) #62066 cli: * (SEMVER-MINOR) add --max-heap-size option (tannal) #58708 crypto: * (SEMVER-MINOR) add TurboSHAKE and KangarooTwelve Web Cryptography algorithms (Filip Skokan) #62183 repl: * (SEMVER-MINOR) add customizable error handling (Anna Henningsen) #62188 * (SEMVER-MINOR) remove dependency on domain module (Matteo Collina) #61227 sea: * (SEMVER-MINOR) support code cache for ESM entrypoint in SEA (Joyee Cheung) #62158 stream: * (SEMVER-MINOR) add stream/iter Implementation (James M Snell) #62066 test: * (SEMVER-MINOR) add tests for experimental stream/iter implementation (James M Snell) #62066 test_runner: * add exports option for module mocks (sangwook) #61727 PR-URL: #62522
aduh95 added a commit that referenced this pull request
Notable changes: async_hooks: * (SEMVER-MINOR) add using scopes to `AsyncLocalStorage` (Stephen Belanger) #61674 cli: * (SEMVER-MINOR) add `--max-heap-size` option (tannal) #58708 crypto: * (SEMVER-MINOR) add TurboSHAKE and KangarooTwelve Web Cryptography algorithms (Filip Skokan) #62183 repl: * (SEMVER-MINOR) add customizable error handling (Anna Henningsen) #62188 * (SEMVER-MINOR) remove dependency on `node:domain` (Matteo Collina) #61227 sea: * (SEMVER-MINOR) support code cache for ESM entrypoint in SEA (Joyee Cheung) #62158 stream: * (SEMVER-MINOR) add stream/iter Implementation (James M Snell) #62066 test_runner: * add exports option for module mocks (sangwook) #61727 PR-URL: #62522
aduh95 added a commit that referenced this pull request
Notable changes: async_hooks: * (SEMVER-MINOR) add using scopes to `AsyncLocalStorage` (Stephen Belanger) #61674 cli: * (SEMVER-MINOR) add `--max-heap-size` option (tannal) #58708 crypto: * (SEMVER-MINOR) add TurboSHAKE and KangarooTwelve Web Cryptography algorithms (Filip Skokan) #62183 repl: * (SEMVER-MINOR) add customizable error handling (Anna Henningsen) #62188 * (SEMVER-MINOR) remove dependency on `node:domain` (Matteo Collina) #61227 sea: * (SEMVER-MINOR) support code cache for ESM entrypoint in SEA (Joyee Cheung) #62158 stream: * (SEMVER-MINOR) add stream/iter Implementation (James M Snell) #62066 test_runner: * add exports option for module mocks (sangwook) #61727 PR-URL: #62522
aduh95 added a commit that referenced this pull request
Notable changes: async_hooks: * (SEMVER-MINOR) add using scopes to `AsyncLocalStorage` (Stephen Belanger) #61674 cli: * (SEMVER-MINOR) add `--max-heap-size` option (tannal) #58708 crypto: * (SEMVER-MINOR) add TurboSHAKE and KangarooTwelve Web Cryptography algorithms (Filip Skokan) #62183 repl: * (SEMVER-MINOR) add customizable error handling (Anna Henningsen) #62188 * (SEMVER-MINOR) remove dependency on `node:domain` (Matteo Collina) #61227 sea: * (SEMVER-MINOR) support code cache for ESM entrypoint in SEA (Joyee Cheung) #62158 stream: * (SEMVER-MINOR) add stream/iter Implementation (James M Snell) #62066 test_runner: * add exports option for module mocks (sangwook) #61727 PR-URL: #62522
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request
karan-lrn pushed a commit to karan-lrn/node that referenced this pull request
Notable changes: async_hooks: * (SEMVER-MINOR) add using scopes to `AsyncLocalStorage` (Stephen Belanger) nodejs#61674 cli: * (SEMVER-MINOR) add `--max-heap-size` option (tannal) nodejs#58708 crypto: * (SEMVER-MINOR) add TurboSHAKE and KangarooTwelve Web Cryptography algorithms (Filip Skokan) nodejs#62183 repl: * (SEMVER-MINOR) add customizable error handling (Anna Henningsen) nodejs#62188 * (SEMVER-MINOR) remove dependency on `node:domain` (Matteo Collina) nodejs#61227 sea: * (SEMVER-MINOR) support code cache for ESM entrypoint in SEA (Joyee Cheung) nodejs#62158 stream: * (SEMVER-MINOR) add stream/iter Implementation (James M Snell) nodejs#62066 test_runner: * add exports option for module mocks (sangwook) nodejs#61727 PR-URL: nodejs#62522
This was referenced