◐ Shell
clean mode source ↗

http: set socket timeout when socket connects by lpinca · Pull Request #8895 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added the http

Issues or PRs related to the http subsystem.

label

Oct 2, 2016

evanlucas

addaleax

cjihrig

jasnell

lpinca referenced this pull request in sindresorhus/timed-out

Jan 16, 2017

lpinca added a commit to lpinca/node that referenced this pull request

Nov 6, 2017 
Fixes a bug that prevented `ClientRequest.prototype.setTimeout()` from
working properly when the socket was reused for multiple requests.

Fixes: nodejs#16716
Refs: nodejs#8895

lpinca added a commit that referenced this pull request

Nov 6, 2017 
Fixes a bug that prevented `ClientRequest.prototype.setTimeout()` from
working properly when the socket was reused for multiple requests.

Fixes: #16716
Refs: #8895
PR-URL: #16725
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

cjihrig pushed a commit to cjihrig/node that referenced this pull request

Nov 6, 2017 
Fixes a bug that prevented `ClientRequest.prototype.setTimeout()` from
working properly when the socket was reused for multiple requests.

Fixes: nodejs#16716
Refs: nodejs#8895
PR-URL: nodejs#16725
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

This was referenced

Dec 19, 2018

jbunton-atlassian added a commit to jbunton-atlassian/node that referenced this pull request

Dec 19, 2018

jbunton-atlassian added a commit to jbunton-atlassian/node that referenced this pull request

Dec 19, 2018

jbunton-atlassian added a commit to jbunton-atlassian/node that referenced this pull request

Dec 19, 2018

jbunton-atlassian added a commit to jbunton-atlassian/node that referenced this pull request

Dec 19, 2018

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2018 
Refs: #8895

PR-URL: #25123
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 26, 2018 
Refs: #8895

PR-URL: #25123
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

vsemozhetbyt pushed a commit that referenced this pull request

Jan 9, 2019 
PR-URL: #25121
Refs: #8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax pushed a commit that referenced this pull request

Jan 14, 2019 
PR-URL: #25121
Refs: #8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Jan 16, 2019 
PR-URL: nodejs#25121
Refs: nodejs#8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg pushed a commit that referenced this pull request

Feb 28, 2019 
Refs: #8895

PR-URL: #25123
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Apr 28, 2019 
PR-URL: #25121
Refs: #8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs pushed a commit that referenced this pull request

May 10, 2019 
PR-URL: #25121
Refs: #8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

May 16, 2019 
PR-URL: #25121
Refs: #8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>