lib: update outdated comment by tanujasawant · Pull Request #8988 · nodejs/node
Conversation
Checklist
- commit message follows commit guidelines
Affected core subsystem(s)
comments
Description of change
Updated an outdated comment in child_process.js to describe the code better.
| if (!Array.isArray(options.stdio)) { | ||
| // Leave stdin open for the IPC channel. stdout and stderr should be the | ||
| // same as the parent's if silent isn't set. | ||
| // Use a separate fd=3 for IPC channel. Inherit stdin, stdout, and stderr |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave "the" in front of "IPC channel".
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm I have left out the 'the'
@cjihrig
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I mean please leave it as it was. In other words, have it say "for the IPC channel."
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okay, thanks. It's done =)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jasnell, when will this commit be merged into nodejs:master ?
jasnell pushed a commit that referenced this pull request
PR-URL: #8988 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged! Landed in 835fbee! Thank you @Tanuja-Sawant !
jasnell pushed a commit that referenced this pull request
PR-URL: #8988 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request
PR-URL: #8988 Reviewed-By: James M Snell <jasnell@gmail.com>