timers: prevent infinite loop when subsequent immediates are cleared by hassy · Pull Request #9759 · nodejs/node

nodejs-github-bot

added the timers

label

Nov 23, 2016

hassy changed the title ~~timers: prevent infinite loop when subsequent immediates are cleared~~ timers: prevent infinite loop when subsequent immediates are cleared - WIP

Nov 23, 2016

hassy changed the title ~~timers: prevent infinite loop when subsequent immediates are cleared - WIP~~ timers: prevent infinite loop when subsequent immediates are cleared

Nov 30, 2016

hassy mentioned this pull request

Dec 7, 2016

If current immediate has no callback, move on to the next one in
the queue.

Fixes: nodejs#9756
PR-URL: nodejs#9759

Fishrock123 pushed a commit that referenced this pull request

Dec 14, 2016

If current immediate has no callback, move on to the next one in
the queue.

Fixes: #9756
PR-URL: #9759
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 15, 2016

If current immediate has no callback, move on to the next one in
the queue.

Fixes: #9756
PR-URL: #9759
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

italoacasas pushed a commit that referenced this pull request

Dec 15, 2016

Notable changes

SEMVER-MINOR
- url:
    - add inspect function to TupleOrigin (Safia Abdalla) #10039
- crypto:
    - allow adding extra certs to well-known CAs (Sam Roberts) #9139

SEMVER-PATCH
- buffer:
    - fix single-character string filling (Anna Henningsen) #9837
    - handle UCS2 .fill() properly on BE (Anna Henningsen) #9837
- url:
    - including base argument in originFor (joyeecheung) #10021
    - improve URLSearchParams spec compliance (Timothy Gu) #9484
- http:
    - remove stale timeout listeners (Karl Böhlmark) #9440
- build:
    - fix node_g target (Daniel Bevenius) #10153
- fs:
    - remove unused argument from copyObject() (Ethan Arrowood) #10041
- timers:
    - fix handling of cleared immediates (hveldstra) #9759

PR-URL: #10277

italoacasas pushed a commit that referenced this pull request

Dec 17, 2016

Notable changes:
* **crypto**:
  - Allow adding extra certificates to well-known CAs. (Sam Roberts)
    [#9139](#9139)
* **buffer**:
  - Fix single-character string filling. (Anna Henningsen)
    [#9837](#9837)
  - Handle UCS2 `.fill()` properly on BE. (Anna Henningsen)
    [#9837](#9837)
* **url**:
  - Add inspect function to TupleOrigin. (Safia Abdalla)
    [#10039](#10039)
  - Including base argument in originFor. (joyeecheung)
    [#10021](#10021)
  - Improve URLSearchParams spec compliance. (Timothy Gu)
    [#9484](#9484)
* **http**:
  - Remove stale timeout listeners. (Karl Böhlmark)
    [#9440](#9440)
* **build**:
  - Fix node_g target. (Daniel Bevenius)
    [#10153](#10153)
* **fs**:
  - Remove unused argument from copyObject(). (EthanArrowood)
    [#10041](#10041)
* **timers**:
  - Fix handling of cleared immediates. (hveldstra)
    [#9759](#9759)
* **src**:
  - Add wrapper for process.emitWarning(). (SamRoberts)
    [#9139](#9139)
  - Fix string format mistake for 32 bit node.(Alex Newman)
    [#10082](#10082)

MylesBorins pushed a commit that referenced this pull request

Jan 22, 2017

If current immediate has no callback, move on to the next one in
the queue.

Fixes: #9756
PR-URL: #9759
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins pushed a commit that referenced this pull request

Jan 24, 2017

If current immediate has no callback, move on to the next one in
the queue.

Fixes: #9756
PR-URL: #9759
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins pushed a commit that referenced this pull request

Jan 31, 2017

If current immediate has no callback, move on to the next one in
the queue.

Fixes: #9756
PR-URL: #9759
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>