fix: ClusterDeployedOperatorExtension should alway apply CRDs before test by csviri · Pull Request #3312 · operator-framework/java-operator-sdk
-
Notifications
You must be signed in to change notification settings - Fork 239
Merged
Conversation
…test Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Copilot AI review requested due to automatic review settings
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it was relying on the LocallyRun case to deploy CRDs?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adjusts the JUnit ClusterDeployedOperatorExtension lifecycle to apply CRDs before running tests, by moving CRD application into the beforeAll phase.
Changes:
- Introduces a
beforeAllImpl(...)override intended to apply CRDs before executing superclassbeforeAlllogic. - Renames/extracts the prior
before(...)logic into a newapplyCrds(...)method.
so it was relying on the LocallyRun case to deploy CRDs?
It seems to :)
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
