fix: revert breaking constructor change in InformerConfiguration by xstefank · Pull Request #3361 · operator-framework/java-operator-sdk
-
Notifications
You must be signed in to change notification settings - Fork 239
Merged
Conversation
Signed-off-by: xstefank <xstefank122@gmail.com>
Copilot AI review requested due to automatic review settings
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR restores a previously removed constructor parameter on InformerConfiguration to undo a breaking API/signature change and updates the copy-builder path accordingly.
Changes:
- Reintroduces the
ghostResourceCacheCheckIntervalparameter in the protectedInformerConfigurationconstructor (marked inline as slated for removal). - Updates
builder(InformerConfiguration<R> original)to pass a value (null) for the reintroduced parameter.
Comment on lines 71 to 75
| FieldSelector fieldSelector, | ||
| Boolean comparableResourceVersions) { | ||
| Boolean comparableResourceVersions, | ||
| // TODO for removal in major release | ||
| Duration ghostResourceCacheCheckInterval) { | ||
| this(resourceClass); |
Comment on lines 120 to +124
| original.itemStore, | ||
| original.informerListLimit, | ||
| original.fieldSelector, | ||
| original.comparableResourceVersions) | ||
| original.comparableResourceVersions, | ||
| null) |
Do we really need this, also on protected constructor?
what is the main reason behind this?
It breaks QOSDK. And it is a public API. Users can also extend it and call the constructor. Not possible to do this in micro release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
