◐ Shell
clean mode source ↗

ext/(standard|spl): Deprecate passing a non-empty string as the $escape parameter by Girgias · Pull Request #15362 · php/php-src

Girgias

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Girgias

@Girgias Girgias commented

Aug 12, 2024

Copy link Copy Markdown

Member

GPHemsley reacted with thumbs down emoji

@cmb69 cmb69 left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the nit below, this looks good to me.
Comment thread

ext/spl/spl_directory.c

@Girgias Girgias merged commit c818d94 into php:master

Aug 12, 2024

@Girgias Girgias deleted the step2-csv-rfc branch

August 12, 2024 15:10

@Girgias Girgias changed the title ext/(standard|spl): Deprecate passing a non-empty string as the $enclosure parameter ext/(standard|spl): Deprecate passing a non-empty string as the $escape parameter

Dec 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimWolla TimWolla

TimWolla left review comments

@cmb69 cmb69

cmb69 approved these changes

@bukka bukka

Awaiting requested review from bukka bukka is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Girgias @TimWolla @cmb69