Add "SI extended" formatting rule for the tick exponents by dberardi99 · Pull Request #7249 · plotly/plotly.js
Merged
Conversation
LGTM, thanks @dberardi99! It’ll need a draftlog entry, I’d call it an addition rather than a bug fix. @archmoj I see you have this slotted for the next release after 3.0, sounds reasonable, I’ll defer to you for a final review
@dberardi99 Could you please resolve the conflicts with master?
@emilykl @camdecoster The changes here LGTM. Fixed the merge conflict in src/plots/cartesian/axes.js.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions for improving the clarity of the code, but LGTM!
@dberardi99 Please add a new draftlog file in draftlogs/ describing this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters