◐ Shell
clean mode source ↗

fix: Resolve incorrect shape clipping for domain-referenced shapes on n*10th subplot by emilykl · Pull Request #7576 · plotly/plotly.js

Closes #7463, closes #6362

Resolves issue where shapes referenced to the domain of an axis id containing a zero (e.g. ref: 'x10 domain') were not clipped to the boundaries of the subplot, as they should have been.

Also adds an image mock for this issue to prevent regression.

Thanks to @Ike-lag and @DataScienceIsCool for reporting, and to @Ike-lag for identifying the faulty regex in the codebase!

Before:
7463_before

After:
7463_after

Steps for testing

  1. View the new zz_shapes_clipping_double_digit_subplots mock in the devtools dashboard (after running npm run build) and make sure the shapes in the lower-left subplot do not extend beyond the subplot boundaries
  2. If you want to see what the mock looks like on master, check out master, copy over the zz_shapes_clipping_double_digit_subplots.json file into the mocks dir, run npm run build and then check the mock in the devtools dashboard.