feat: Build list of included ISO country codes by camdecoster · Pull Request #7622 · plotly/plotly.js
-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Conversation
Description
Update topojson build script to generate a list of ISO country codes.
Closes #7621.
Changes
- Update build script
- Update info related to disputed territories
Testing
- Be on this branch
- In a terminal, cd into the topojson folder
- Run
npm run build(this could take a bit to download the required files) - Check the resulting list in the dist folder and make sure it includes the name and ISO code
- Open the countries map (topojson/build/geojson/un_geodata_simplified_50m/countries.geojson) in Mapshaper and run the following command in the console:
-filter '["XBT", "XHT", "XAC", "XAP", "XIT"].includes(iso3cd)' - Verify that there are 5 polygons and that they include the following disputed territories:
- Ilemi Triangle
- Halaib Triangle
- Bir Tawil
- Aksai Chin
- Arunachal Pradesh
Notes
- Since the maps are being updated, these will need to be included in the next plotly.js release
TODO
- Add draftlog
@camdecoster What is the impact of this change? (Could you open an issue? 😉 )
I created #7621 but forgot to add it to the OP. I updated it.
@camdecoster This has no impact on the library itself, correct?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
camdecoster
deleted the
cam/7621/build-list-iso-country-codes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters