◐ Shell
clean mode source ↗

feat: Add `--no-fail-fast` CLI option to override fail-fast behavior by anthonyhaussman · Pull Request #3710 · pre-commit/pre-commit

Conversation

@anthonyhaussman

Introduce a mutually exclusive --no-fail-fast CLI argument alongside --fail-fast.

This option allows disabling fail-fast behavior even if it has been enabled globally in the config or at the individual hook level.
Also update hook-impl to safely support the no_fail_fast attribute.

Introduce a mutually exclusive --no-fail-fast CLI argument alongside --fail-fast. This option allows disabling fail-fast behavior even if it has been enabled globally in the config or at the individual hook level. Also update hook-impl to safely support the no_fail_fast attribute.

Assisted-by: Gemini 3.5 Flash

@asottile

I don't think this is a good idea. if it's misconfigured just fix the config

@anthonyhaussman

Well, the goal was to enable fail-fast in the configuration file for local execution, but run the CI steps with --no-fail-fast.

But I'll find another way. 🙏

2 participants

@anthonyhaussman @asottile