◐ Shell
clean mode source ↗

check also directories in check_case_conflict by slsyy · Pull Request #575 · pre-commit/pre-commit-hooks

asottile

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@slsyy

@slsyy slsyy commented

Mar 19, 2021

Copy link Copy Markdown

Contributor

fix #70

@slsyy slsyy force-pushed the master branch 2 times, most recently from e567150 to fd797fa Compare

March 19, 2021 19:36

@slsyy

slsyy commented

Mar 21, 2021

Copy link Copy Markdown

Contributor Author

@asottile please re-review

@asottile asottile left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few small things -- sorry for the delay I've been very busy

@asottile asottile left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slsyy reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

check-case-conflict doesn't notice directory name conflicts

2 participants

@slsyy @asottile