don't rewrite string quotes inside f-strings by asottile · Pull Request #973 · pre-commit/pre-commit-hooks
pre-commit / pre-commit-hooks Public
-
-
Notifications
You must be signed in to change notification settings - Fork 792
Merged
Merged
Conversation
asottile
merged commit
ae9b59f
into
main
asottile
deleted the
string-fixer-3-12
branch
iFurySt
mentioned this pull request
SachiaLanlus
mentioned this pull request
espressif-bot pushed a commit to espressif/esp-idf-size that referenced this pull request
Python 3.12 and later versions support nested strings in f-strings (PEP 701) and have modified the tokenize module. However, this update was not incorporated into the double-quote-string-fixer (string_fixer.py) hook of pre-commit. The issue[1] is resolved[2] in pre-commit version 4.5.0[3]. Upgrade to pre-commit 4.5.0 to prevent incorrect reformatting of f-strings. [1] pre-commit/pre-commit-hooks#971 [2] https://github.com/pre-commit/pre-commit-hooks/blob/main/CHANGELOG.md#450---2023-10-07 [3] pre-commit/pre-commit-hooks#973 Signed-off-by: Frantisek Hrbata <frantisek.hrbata@espressif.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment