migrating Preferences and Messages to stand-alone version by AhmedMagedC · Pull Request #1130 · processing/processing4

Stefterv

Hi @AhmedMagedC Sorry it took me so long to take a look at your PR again! and again thank you for your efforts, it's helping me a lot trying figure out how to refactor some of these intertwined elements.

Looking at your PR and #1164 I think it is important moving forward that we only migrate one class at a time. I would suggest that any functionality in the Preferences class that is currently causing you to have to migrate the Messages and Base classes for example, should be taken out of the Preferences class. That will make the code a little bit more flexible in the future.

Hi @Stefterv , It's okay it's also the first time for me trying to refactor a codebase by decoupling tightly-coupled classes

im not sure i follow you,
if i were to move Messages back to app module, how might we decouple Preferences from using it?

also for the change of getting the setting folder for each OS is now independent of Base class, i dont think i should undo this change it will make Preferences impossible to be a standalone class