Debugger continues to work despite Sketch name and folder name are not equal by awood0727 · Pull Request #1197 · processing/processing4

SableRaf

Resolves

This PR resolves #1190

Changes

Modified line 211 in java/src/processing/mode/java/debug/LineBreakpoint.java to allow .pde files to return its filename
Inserted a new function in java/src/processing/mode/java/debug/Debugger.java to check and translate PDE files if they are mismatched with their folder.

Tests

We ran ./gradlew test, built successfully.
Ran ./gradlew run, built IDE successfully.
Tested the debugger to notice any change in its behavior.

Screenshots

Before Implementation

After Implementation

Signed-off-by: Amante' Woodley <awood0727@gmail.com>

Co-authored-by: Nia Perez <nia.perez.506@gmail.com>
Co-authored-by: Kayla Bobo <kay3583@gmail.com>
Co-authored-by: Silas Morgan <victorsmorgan@gmail.com>

hi @awood0727 and crew, thank you for fixing this! I just have a quick question about the Debugger.pdeToSketchLine, it seems to not be used/referenced anywhere and your fix works without it too, could you clarify why this was added?

Hello @Stefterv, our thought process with the Debugger.pdeToSketchLine code was due to us creating a similar return line for the .pde files like was given for the .java files in LineBreakpoint.java we assumed that we needed to also create a similar function in Debugger. However if you believe that functions is not needed than we can take the code out if you would like us too.

Yeah if the function is unused, which it seems to be, please remove it. Great work!

Apologies for the delay but the fix should be implemented by the end of the week, my classes started a couple weeks ago so I'm trying to find a good time.

Hey @Stefterv, we have created a pull request with the appropriate changes in PR #1227 thank you for all of your help and we hope you all are having an amazing weekend!

Hey @awood0727 great thank you! Can you please close this PR then?