Display Welcome to Beta once per revision by catilac · Pull Request #1203 · processing/processing4
Limits the Welcome to Beta screen to once per downloaded revision.
Closes #1198
Comment on lines +145 to +148
| System.err.println("MOON DEBUG" + | ||
| Base.getRevision() + ", and lastBetaSeen is " + | ||
| lastBetaSeen + "."); | ||
|
|
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove this, i suppose
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, feel free to use Messages.log that will be hidden for users and will give us valuable information when looking at the logs
| JFrame(windowTitle).apply { | ||
| val close = { dispose() } | ||
| val close = { | ||
| Preferences.set("beta.last_beta_welcome_seen", getRevision().toString()) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i need a better key name. wondering your thoughts. should it be update.beta_welcome or something?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update.beta_prompt
| if(latest < Base.getRevision()){ | ||
| WelcomeToBeta.showWelcomeToBeta(); | ||
|
|
||
| String lastBetaSeenStr = Preferences.get("beta.last_beta_welcome_seen"); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say using Preferences.getInteger() would be a better choice here, to make sure it is never empty you can add the key to the defaults.txt in build/shared/lib/defaults.txt
WIP: Display once per revision number
Display Welcome to Beta once per revision
