Read preferences txt, if fails, read defaults, else really break by catilac · Pull Request #1393 · processing/processing4
-
-
Notifications
You must be signed in to change notification settings - Fork 171
Merged
Conversation
In a quick test it seems to work 👍 Thanks @catilac
Here's what I did:
Replicating
- Opened Processing 4.5.1
- Opened the preferences
- Searched for "tabs"
- Set
editor.tabs.sizeto4/(causes error in the console) - Closed and re-opened. Got the error from Preferences not validating inputs #1388
Testing the PR
- Built from PR branch (runs successfullly)
- Opened the preferences
- Searched for "tabs"
- Set
editor.tabs.sizeto4(removed the trailing/) - Closed Processing
- Re-opened 4.5.1. (starts successfully)
@catilac What's your take on adding comments in the code to explain why a workaround like this one was needed?
@SableRaf i think generally that's a great idea! For this particular patch it's more like coding with a so-called best practice so it's not something too out of the ordinary. Thanks so much for reviewing will merge!
catilac
deleted the
parse_int_exception
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters