Add parsing related unit tests for JSONArray by satindra-r · Pull Request #1484 · processing/processing4
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, i've added a comment about some stylistic changes!
Comment on lines +193 to +196
| String json = "[\n" + | ||
| "null,\n" + | ||
| "null\n" + | ||
| "]"; |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just make this one string instead of multiple addition operations?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I forgot that raw strings were added in java 13. I've made all the json strings into raw strings
Comment on lines +204 to +207
| String json = "[\n" + | ||
| "1,\n" + | ||
| "2\n" + | ||
| "]"; |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above, this only makes things more difficult to read