make patchcheck: Allow Tabs in Some Cases
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Closed as not planned
Closed as not planned
Description
Currently Tools/patchcheck/reindent.py1 replaces all tabs with spaces. However, in Tools/c-analyzer/cpython._parser.py there are embedded tab-based tables. Up to now I've basically ignored CI failures (from make patchcheck) in _parser.py, but I'd rather reindent.py be a little smarter (even if just a whitelist). 2 Tools/scripts/untabify.py sounds like it may have a similar story.
Linked PRs
- gh-92266: Replace tabs with four spaces in Python files #135983
- gh-92266: reindent.py: Add allowlist for files with tabs #135984
- [3.14] gh-92266: Replace tabs with four spaces in Python files (GH-135983) #136035
- [3.13] gh-92266: Replace tabs with four spaces in Python files (GH-135983) #136036
- GH-92266: Remove embedded tabs from
c-analyzer/cpython/_parser.py#137622 - gh-92266: Update pre-commit #139411
- [3.14] gh-92266: Update pre-commit (GH-139411) #139466
- [3.14] GH-92266: Remove embedded tabs from
c-analyzer/cpython/_parser.py(GH-137622) #139718 - [3.13] gh-92266: Update pre-commit (GH-139411) #139760
Footnotes
-
reindent.check()is used by Tools/patchcheck/patchcheck.py (AKAmake patchcheck). ↩ -
Addressing trailing-tabs-in-str-literals is even more relevant since I enabled the check-c-globals CI check. For example, see https://github.com/python/cpython/pull/102735#issuecomment-1470516458. ↩
Metadata
Metadata
Assignees
No one assigned
Fields
No fields configured for issues without a type.
Projects
No projects
Milestone
No milestone
Relationships
None yet
Development
No branches or pull requests