gh-81057: Move the Cached Parser Dummy Name to _PyRuntimeState by ericsnowcurrently · Pull Request #100277 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
merged 2 commits into
Conversation
Member
We have been lazily creating a singleton parser node in _PyPegen_dummy_name() and cached it in a static variable. Here we instead statically define/initialize the node as part of _PyRuntimeState. This eliminates one of the remaining global variables, reduces run-time CPU time (and memory usage), and eliminates a minor memory leak.
ericsnowcurrently added 2 commits
ericsnowcurrently
added
the
skip news
label
ericsnowcurrently
requested review from
lysnikolaou and
pablogsal
as code owners
bedevere-bot
mentioned this pull request
✅ Deploy Preview for python-cpython-preview canceled.
| Name | Link |
|---|---|
| 🔨 Latest commit | 2d0876e |
| 🔍 Latest deploy log | https://app.netlify.com/sites/python-cpython-preview/deploys/639b7881dc1c18000881c4d3 |
bedevere-bot
added
the
awaiting core review
label
pablogsal
approved these changes
pablogsal
left a comment
pablogsal
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
pablogsal
merged commit
0415cf8
into
python:main
bedevere-bot
removed
the
awaiting merge
label
ericsnowcurrently
deleted the
static-parser-dummy-name
branch
carljm added a commit to carljm/cpython that referenced this pull request
* main: Improve stats presentation for calls. (pythonGH-100274) Better stats for `LOAD_ATTR` and `STORE_ATTR` (pythonGH-100295) pythongh-81057: Move the Cached Parser Dummy Name to _PyRuntimeState (python#100277) Document that zipfile's pwd parameter is a `bytes` object (python#100209) pythongh-99767: mark `PyTypeObject.tp_watched` as internal use only in table (python#100271) Fix typo in introduction.rst (python#100266) pythongh-78997: AttributeError if loading fails in LibraryLoader.__getattr__ pythonGH-100234: Set a default value for random.expovariate() (pythonGH-100235) Remove uninformative itertools recipe (pythonGH-100253) pythonGH-99767: update PyTypeObject docs for type watchers (pythonGH-99928) Move stats for the method cache into the `Py_STAT` machinery (pythonGH-100255) pythonGH-100222: fix typo _py_set_opocde -> _py_set_opcode (pythonGH-100259) pythonGH-100000: Cleanup and polish various watchers code (pythonGH-99998) pythongh-90111: Minor Cleanup for Runtime-Global Objects (pythongh-100254)
shihai1991 added a commit to shihai1991/cpython that referenced this pull request
* origin/main: (1306 commits) Correct CVE-2020-10735 documentation (python#100306) pythongh-100272: Fix JSON serialization of OrderedDict (pythonGH-100273) pythongh-93649: Split tracemalloc tests from _testcapimodule.c (python#99551) Docs: Use `PY_VERSION_HEX` for version comparison (python#100179) pythongh-97909: Fix markup for `PyMethodDef` members (python#100089) pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890) pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890) pythonGH-98831: Add DECREF_INPUTS(), expanding to DECREF() each stack input (python#100205) pythongh-78707: deprecate passing >1 argument to `PurePath.[is_]relative_to()` (pythonGH-94469) pythongh-99540: Constant hash for _PyNone_Type to aid reproducibility (pythonGH-99541) pythongh-100039: enhance __signature__ to work with str and callables (pythonGH-100168) pythongh-99830: asyncio: Document returns of remove_{reader,writer} (python#100302) "Compound statement" docs: Fix with-statement step indexing (python#100286) pythonGH-90043: Handle NaNs in COMPARE_OP_FLOAT_JUMP (pythonGH-100278) Improve stats presentation for calls. (pythonGH-100274) Better stats for `LOAD_ATTR` and `STORE_ATTR` (pythonGH-100295) pythongh-81057: Move the Cached Parser Dummy Name to _PyRuntimeState (python#100277) Document that zipfile's pwd parameter is a `bytes` object (python#100209) pythongh-99767: mark `PyTypeObject.tp_watched` as internal use only in table (python#100271) Fix typo in introduction.rst (python#100266) ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment