gh-100321: Remove redundant variable newfree in function analyze_block by zikcheng · Pull Request #100327 · python/cpython
Conversation
Contributor
bedevere-bot
mentioned this pull request
bedevere-bot
added
the
awaiting review
label
kumaraditya303
requested review from
iritkatriel and
markshannon
kumaraditya303
added
the
skip news
label
JosephSBoyle
left a comment
JosephSBoyle
left a comment
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi.
What do the "newfree" and "allfree" vars represent?
zikcheng
commented
Dec 18, 2022
zikcheng commented
Contributor Author
Hi @JosephSBoyle , in my understanding, allfree represents all free variables in children blocks and newfree is just a copy of allfree.
JosephSBoyle
commented
Dec 21, 2022
JosephSBoyle commented
Contributor
@zikcheng Thanks for clarifying for me:)
encukou
commented
Apr 10, 2024
encukou commented
Member
In #101441, the allfree variable was removed instead.
Sorry that we missed this PR!
encukou
closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment