◐ Shell
clean mode source ↗

gh-100321: Remove redundant variable newfree in function analyze_block by zikcheng · Pull Request #100327 · python/cpython

Conversation

@zikcheng

@zikcheng zikcheng commented

Dec 18, 2022

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

@JosephSBoyle JosephSBoyle left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi.
What do the "newfree" and "allfree" vars represent?

@zikcheng

Copy link Copy Markdown

Contributor Author

Hi @JosephSBoyle , in my understanding, allfree represents all free variables in children blocks and newfree is just a copy of allfree.

@JosephSBoyle

Copy link Copy Markdown

Contributor

@zikcheng Thanks for clarifying for me:)

@encukou

encukou commented

Apr 10, 2024

Copy link Copy Markdown

Member

In #101441, the allfree variable was removed instead.

Sorry that we missed this PR!

@encukou encukou closed this

Apr 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

@markshannon markshannon Awaiting requested review from markshannon

1 more reviewer

@JosephSBoyle JosephSBoyle JosephSBoyle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zikcheng @JosephSBoyle @encukou @bedevere-bot @kumaraditya303