◐ Shell
clean mode source ↗

gh-100540: Remove unnecessary '-DMACOSX' for ctypes on macOS by zware · Pull Request #100542 · python/cpython

zware

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@zware

@zware zware commented

Dec 26, 2022

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

The define was only used to protect a #pragma clang diagnostic
setting, which is already better guarded by __clang__ anwyay.
erlend-aasland reacted with thumbs up emoji 
The define was only used to protect a `#pragma clang diagnostic`
setting, which is already better guarded by `__clang__` anwyay.

@zware zware added 3.12

only security fixes

OS-mac build

The build process and cross-build

topic-ctypes extension-modules

C modules in the Modules dir

skip news labels

Dec 26, 2022

@zware zware self-assigned this

Dec 26, 2022

@zware zware requested a review from a team

December 26, 2022 21:27

@zware

zware commented

Dec 26, 2022

Copy link Copy Markdown

Member Author

!buildbot .*mac

@bedevere-bot

Copy link Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zware for commit 774c213 🤖

The command will test the builders whose names match following regular expression: .*mac

The builders matched are:

  • ARM64 macOS PR
  • x86-64 macOS PR

@zware zware merged commit fd4b55f into python:main

Dec 28, 2022

@zware zware deleted the remove_unnecessary_define branch

December 28, 2022 18:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@zware zware

Labels

3.12

only security fixes

build

The build process and cross-build

extension-modules

C modules in the Modules dir

OS-mac skip news topic-ctypes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zware @bedevere-bot