◐ Shell
clean mode source ↗

GH-100766: Note that locale.LC_MESSAGES is not universal (GH-100702) by uranusjr · Pull Request #100702 · python/cpython

bedevere-bot

Conversation

@uranusjr

The LC_MESSAGES value in locale is not universally available. The value is generally imported from C headers through localemodule.c. The sourc notes this specifically:

# Yuck: LC_MESSAGES is non-standard: can't tell whether it exists before
# trying the import. So __all__ is also fiddled at the end of the file.

This makes the fact more visible to users only reading the documentation.

@FFY00 FFY00 mentioned this pull request

Jan 5, 2023

@FFY00 FFY00 changed the title Doc: Note that locale.LC_MESSAGES is not universal GH-100766: Note that locale.LC_MESSAGES is not universal

Jan 5, 2023

FFY00

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FFY00 FFY00 changed the title GH-100766: Note that locale.LC_MESSAGES is not universal GH-100766: Note that locale.LC_MESSAGES is not universal (GH-100702)

Jan 5, 2023

@miss-islington

Thanks @uranusjr for the PR, and @FFY00 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 5, 2023 
…nGH-100702)

(cherry picked from commit 105e373)

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>

@bedevere-bot

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 5, 2023 
…nGH-100702)

(cherry picked from commit 105e373)

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>

@uranusjr uranusjr deleted the doc-locale-lc-messages-optional branch

January 5, 2023 04:56

carljm added a commit to carljm/cpython that referenced this pull request

Jan 5, 2023

carljm added a commit to carljm/cpython that referenced this pull request

Jan 5, 2023

Labels