◐ Shell
clean mode source ↗

GH-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. by markshannon · Pull Request #100753 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@markshannon

@markshannon markshannon commented

Jan 4, 2023

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

Stats show that it doesn't work. It represents about 0.02% of the instructions executed and its miss rate is over 90%.

@markshannon markshannon changed the title Remove LOAD_ATTR_METHOD_WITH_DICT instruction. Gh-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction.

Jan 4, 2023

@markshannon markshannon changed the title Gh-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. GH-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction.

Jan 4, 2023

@markshannon markshannon merged commit f20c553 into python:main

Jan 5, 2023

@markshannon markshannon deleted the remove-load-attr-method-with-dict branch

January 5, 2023 12:20

carljm added a commit to carljm/cpython that referenced this pull request

Jan 5, 2023
* main:
  pythonGH-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. (pythonGH-100753)
  pythonGH-100766: Note that locale.LC_MESSAGES is not universal (pythonGH-100702)

carljm added a commit to carljm/cpython that referenced this pull request

Jan 5, 2023
* main:
  pythonGH-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. (pythonGH-100753)
  pythonGH-100766: Note that locale.LC_MESSAGES is not universal (pythonGH-100702)
  Drop myself from pathlib maintenance (python#100757)
  pythongh-100739: Respect mock spec when checking for unsafe prefixes (python#100740)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markshannon @Fidget-Spinner @bedevere-bot