◐ Shell
clean mode source ↗

gh-100783: fix os.path.join documentation by hauntsaninja · Pull Request #100811 · python/cpython

- Use "drive", not "drive letter", because of UNC paths
- Previous components are not thrown away from relative drive letters
- Use "segment" instead of "component" for consistency with pathlib

See issue for more details

eryksun

eryksun

JelleZijlstra

@hauntsaninja

hauntsaninja

@hauntsaninja

eryksun

@hauntsaninja

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 8, 2023
- Use "drive", not "drive letter", because of UNC paths
- Previous components are not thrown away from relative drive letters
- Use "segment" instead of "component" for consistency with pathlib
- Other miscellaneous improvements
(cherry picked from commit 53455a3)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 8, 2023
- Use "drive", not "drive letter", because of UNC paths
- Previous components are not thrown away from relative drive letters
- Use "segment" instead of "component" for consistency with pathlib
- Other miscellaneous improvements
(cherry picked from commit 53455a3)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

miss-islington added a commit that referenced this pull request

Jan 8, 2023
- Use "drive", not "drive letter", because of UNC paths
- Previous components are not thrown away from relative drive letters
- Use "segment" instead of "component" for consistency with pathlib
- Other miscellaneous improvements
(cherry picked from commit 53455a3)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

miss-islington added a commit that referenced this pull request

Jan 8, 2023
- Use "drive", not "drive letter", because of UNC paths
- Previous components are not thrown away from relative drive letters
- Use "segment" instead of "component" for consistency with pathlib
- Other miscellaneous improvements
(cherry picked from commit 53455a3)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull request

Jan 29, 2023
This is a follow-up to python#100811.

One of the changes in that PR isn't accurate in that
`os.path.join('', '')` will not end in a separator.

This reverts that change to the previous wording that used "only", but
explicitly calls out the case where the last part ends in a separator,
which is what caused confusin in python#77607 and motivated the change
in python#100811.

hauntsaninja added a commit that referenced this pull request

Jan 31, 2023
This is a follow-up to #100811.

One of the changes in that PR isn't accurate in that
`os.path.join('', '')` will not end in a separator.

This reverts that change to the previous wording that used "only", but
explicitly calls out the case where the last part ends in a separator,
which is what caused confusin in #77607 and motivated the change
in #100811.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 31, 2023
This is a follow-up to pythonGH-100811.

One of the changes in that PR isn't accurate in that
`os.path.join('', '')` will not end in a separator.

This reverts that change to the previous wording that used "only", but
explicitly calls out the case where the last part ends in a separator,
which is what caused confusin in pythonGH-77607 and motivated the change
in pythonGH-100811.
(cherry picked from commit 909a674)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 31, 2023
This is a follow-up to pythonGH-100811.

One of the changes in that PR isn't accurate in that
`os.path.join('', '')` will not end in a separator.

This reverts that change to the previous wording that used "only", but
explicitly calls out the case where the last part ends in a separator,
which is what caused confusin in pythonGH-77607 and motivated the change
in pythonGH-100811.
(cherry picked from commit 909a674)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

miss-islington added a commit that referenced this pull request

Jan 31, 2023
This is a follow-up to GH-100811.

One of the changes in that PR isn't accurate in that
`os.path.join('', '')` will not end in a separator.

This reverts that change to the previous wording that used "only", but
explicitly calls out the case where the last part ends in a separator,
which is what caused confusin in GH-77607 and motivated the change
in GH-100811.
(cherry picked from commit 909a674)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

miss-islington added a commit that referenced this pull request

Jan 31, 2023
This is a follow-up to GH-100811.

One of the changes in that PR isn't accurate in that
`os.path.join('', '')` will not end in a separator.

This reverts that change to the previous wording that used "only", but
explicitly calls out the case where the last part ends in a separator,
which is what caused confusin in GH-77607 and motivated the change
in GH-100811.
(cherry picked from commit 909a674)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

mdboom pushed a commit to mdboom/cpython that referenced this pull request

Jan 31, 2023
This is a follow-up to python#100811.

One of the changes in that PR isn't accurate in that
`os.path.join('', '')` will not end in a separator.

This reverts that change to the previous wording that used "only", but
explicitly calls out the case where the last part ends in a separator,
which is what caused confusin in python#77607 and motivated the change
in python#100811.