◐ Shell
clean mode source ↗

gh-98831: rewrite CHECK_EG_MATCH opcode in the instruction definition DSL by iritkatriel · Pull Request #101269 · python/cpython

Conversation

@iritkatriel

The change in exception_group_match is needed because previously in the case of match == None the opcode didn't look at rest, but now it pushes to the stack (even though it's already there) to keep the code uniform with the match != None case.

gvanrossum

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this one wasn't trivial. Thanks!

gvanrossum

@iritkatriel

I'll kick off the buildbots in case refcount.

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 93d98ab 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@gvanrossum

PPC64 Fedora PR is failing with "No space left on device", so I wouldn't worry about that one. :)

Labels