◐ Shell
clean mode source ↗

gh-98831: rewrite pattern matching opcodes in the instruction definition DSL by iritkatriel · Pull Request #101287 · python/cpython

iritkatriel

Conversation

@iritkatriel

@iritkatriel iritkatriel commented

Jan 24, 2023

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

Separated these out for @brandtbucher to review.

@brandtbucher brandtbucher left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One tiny comment:
Comment thread

Python/bytecodes.c Outdated

@gvanrossum gvanrossum left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but agree with Brandt's suggestion.

@gvanrossum gvanrossum left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@iritkatriel iritkatriel merged commit 1a9d8c7 into python:main

Jan 24, 2023

@iritkatriel iritkatriel deleted the bytecodes branch

April 3, 2023 17:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

No one assigned

Labels

interpreter-core

(Objects, Python, Grammar, and Parser dirs)

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iritkatriel @gvanrossum @brandtbucher @bedevere-bot