◐ Shell
clean mode source ↗

[2.7] bpo-35017, socketserver: don't accept any request after shutdown (GH-9952) by beledouxdenis · Pull Request #10129 · python/cpython

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

…H-9952)

Prior to this revision, after the shutdown of a `BaseServer`,
the server accepted a last single request
if it was sent between the server socket polling
and the polling timeout.

This can be problematic for instance for a server restart
for which you do not want to interrupt the service,
by not closing the listening socket during the restart.
One request failed because of this behavior.

Note that only one request failed,
following requests were not accepted, as expected.

(cherry picked from commit 10cb376)

vstinner

@vstinner vstinner changed the title [2.7] bpo-35017: Lib/socketserver, do not accept any request after shutdown (GH-9952) [2.7] bpo-35017, socketserver: don't accept any request after shutdown (GH-9952)

Oct 26, 2018