◐ Shell
clean mode source ↗

gh-101277: Isolate itertools, part 2/4 by erlend-aasland · Pull Request #101303 · python/cpython

erlend-aasland

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented

Jan 24, 2023

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

Add dropwhile, takewhile, starmap, combinations*, and permutations types to module state

@erlend-aasland erlend-aasland force-pushed the isolate-itertools/batch-2 branch from 2373926 to 29a3485 Compare

February 1, 2023 11:54

@erlend-aasland erlend-aasland marked this pull request as ready for review

February 1, 2023 11:56

@corona10 corona10 added the 🔨 test-with-refleak-buildbots

Test PR w/ refleak buildbots; report in status section

label

Feb 1, 2023

@corona10 corona10 self-requested a review

February 1, 2023 12:25

@bedevere-bot

Copy link Copy Markdown

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 29a3485 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots

Test PR w/ refleak buildbots; report in status section

label

Feb 1, 2023

@corona10 corona10 left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!
erlend-aasland reacted with hooray emoji

@kumaraditya303 kumaraditya303 merged commit a52cc98 into python:main

Feb 3, 2023

@kumaraditya303

Copy link Copy Markdown

Contributor

Thanks @erlend-aasland, onto the next one!
erlend-aasland reacted with hooray emoji

iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request

Feb 3, 2023 
…thon#101303)

Add dropwhile, takewhile, starmap, combinations*, and permutations types to module state.

@erlend-aasland

Copy link Copy Markdown

Contributor Author

Thanks @erlend-aasland, onto the next one!

Thanks, Kumar! I'm on the road these days; I'll try to find the time to prepare part 3 later today.

@erlend-aasland erlend-aasland deleted the isolate-itertools/batch-2 branch

February 3, 2023 15:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @bedevere-bot @kumaraditya303 @corona10