◐ Shell
clean mode source ↗

gh-101322: Ensure test_zlib.ZlibDecompressorTest runs, fix errors in ZlibDecompressor by rhpvorderman · Pull Request #101323 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@rhpvorderman

@rhpvorderman rhpvorderman commented

Jan 25, 2023

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

Turns out that when I made #97664 I added test but these are actually not run at test time.

I also found a small error in the code that is now fixed.

@gpshead gpshead merged commit a89e671 into python:main

Feb 4, 2023

@rhpvorderman

Copy link Copy Markdown

Contributor Author

Thanks for reviewing!

@rhpvorderman rhpvorderman deleted the testfix branch

February 6, 2023 05:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rhpvorderman @gpshead @kumaraditya303 @bedevere-bot