gh-101409: Improve generated clinic code for self type checks by erlend-aasland · Pull Request #101411 · python/cpython

I'm not sure if this improvement is worth it, though; it may be churn for no benefit.

IMHO, this improvement is worth it.

1. If the clinic_state() macro is fairly complicated, the compiler won't eliminate the redundant function invocations.

2. The generated code after this patch is more concise and readable.

1. If the clinic_state() macro is fairly complicated, the compiler won't eliminate the redundant function invocations.

That is true; we cannot guarantee that the compiler will eliminate the redundant calls.

2. The generated code after this patch is more concise and readable.

I agree with this.

Thanks for the review, @colorfulappl; highly appreciated.

self_tp may be not a good name. It is not a type of self. Maybe base_type or declared_type or something?

base_type sounds good; thanks!

I'm considering landing this PR in a day or two. With three thumbs up, I'm landing this tonight.

Thanks for the reviews, y'all!