◐ Shell
clean mode source ↗

gh-98831: rewrite BEFORE_ASYNC_WITH and END_ASYNC_FOR in the instruction definition DSL by iritkatriel · Pull Request #101458 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@iritkatriel

@iritkatriel iritkatriel commented

Jan 31, 2023

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@iritkatriel iritkatriel added topic-asyncio skip news interpreter-core

(Objects, Python, Grammar, and Parser dirs)

labels

Jan 31, 2023

@iritkatriel iritkatriel added the 🔨 test-with-buildbots

Test PR w/ buildbots; report in status section

label

Jan 31, 2023

@bedevere-bot

Copy link Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit a8b3215 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots

Test PR w/ buildbots; report in status section

label

Jan 31, 2023

@gvanrossum gvanrossum left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tough ones! LG.

@gvanrossum

Copy link Copy Markdown

Member

As always, the PPC64 buildbot is out of space.

@iritkatriel iritkatriel merged commit 0062f53 into python:main

Jan 31, 2023

carljm added a commit to carljm/cpython that referenced this pull request

Jan 31, 2023
* main:
  pythonGH-100288: Skip extra work when failing to specialize LOAD_ATTR (pythonGH-101354)
  pythongh-101409: Improve generated clinic code for self type checks (python#101411)
  pythongh-98831: rewrite BEFORE_ASYNC_WITH and END_ASYNC_FOR in the instruction definition DSL (python#101458)
  pythongh-101469: Optimise get_io_state() by using _PyModule_GetState() (pythonGH-101470)

@iritkatriel iritkatriel deleted the async_bytecodes branch

April 3, 2023 17:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Labels

interpreter-core

(Objects, Python, Grammar, and Parser dirs)

skip news topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iritkatriel @bedevere-bot @gvanrossum