◐ Shell
clean mode source ↗

gh-98831: Modernize CALL_FUNCTION_EX by gvanrossum · Pull Request #101627 · python/cpython

Conversation

@gvanrossum

This is a straightforward use of a conditional input stack effect. The one tricky bit is that I had to cherry-pick a fix for CHECK_EVAL_BREAKER() from gh-101508. Whichever lands first, the other will have to drop that commit.

iritkatriel

@gvanrossum

On top of that the tests fail. Going back into draft mode.

Also avoid compiler warning for unused variable 'null'
(used in assert only).

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @gvanrossum for commit 19307ba 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.

@gvanrossum

@iritkatriel Crash fixed, warning fixed, tests passed, refleak buildbots are running. Ready for your review.

iritkatriel

@gvanrossum

I'm taking the PPC64LE RHEL8 Refleaks PR buildbot failure as a flake.

Labels