gh-98831: rewrite UNPACK_EX, UNPACK_SEQUENCE, UNPACK_SEQUENCE_TWO_TUPLE in the instruction definition DSL by iritkatriel · Pull Request #101641 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
Merged
Conversation
Member
labels
bedevere-bot
commented
Feb 7, 2023
bedevere-bot commented
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit e0accbb 🤖
If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.
label
gvanrossum
approved these changes
gvanrossum
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't you also move the family declaration in front of the first instruction of the family? (Where that family is now is effectively commented-out.)
iritkatriel and others added 2 commits
gvanrossum
commented
Feb 7, 2023
gvanrossum commented
Member
LG, I'll take care of the family when I do UNPACK_SEQUENCE_{TUPLE,LIST}.
dec1ab0
into
python:main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
