gh-97786: Fix compiler warnings in pytime.c by mdickinson · Pull Request #101826 · python/cpython

mdickinson

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Feb 20, 2023

Fixes compiler warnings in pytime.c.
(cherry picked from commit b1b375e)

Co-authored-by: Mark Dickinson <dickinsm@gmail.com>

jaraco pushed a commit to jaraco/cpython that referenced this pull request

Feb 20, 2023

Fixes compiler warnings in pytime.c.

carljm added a commit to carljm/cpython that referenced this pull request

Feb 20, 2023

mdickinson added a commit that referenced this pull request

Feb 22, 2023

gh-97786: Fix compiler warnings in pytime.c (GH-101826)

Fixes compiler warnings in pytime.c.
(cherry picked from commit b1b375e)

Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

carljm added a commit to carljm/cpython that referenced this pull request

Feb 22, 2023

mdickinson added a commit that referenced this pull request

Feb 26, 2023

* [3.10] gh-97786: Fix compiler warnings in pytime.c (GH-101826)

Fixes compiler warnings in pytime.c..
(cherry picked from commit b1b375e)

Co-authored-by: Mark Dickinson <dickinsm@gmail.com>

* Add comment about the casts

---------

Co-authored-by: Gregory P. Smith <greg@krypto.org>

This was referenced

Mar 4, 2023

mdickinson added a commit that referenced this pull request

Mar 4, 2023

Since #101826 was merged, the internal macro `_Py_InIntegralTypeRange` is unused, as are its supporting macros `_Py_IntegralTypeMax` and `_Py_IntegralTypeMin`. This PR removes them.

Note that `_Py_InIntegralTypeRange` doesn't actually work as advertised - it's not a safe way to avoid undefined behaviour in an integer to double conversion.

hugovk pushed a commit to hugovk/cpython that referenced this pull request

Mar 6, 2023

Since python#101826 was merged, the internal macro `_Py_InIntegralTypeRange` is unused, as are its supporting macros `_Py_IntegralTypeMax` and `_Py_IntegralTypeMin`. This PR removes them.

Note that `_Py_InIntegralTypeRange` doesn't actually work as advertised - it's not a safe way to avoid undefined behaviour in an integer to double conversion.

mdickinson deleted the fix-pytime-c-compiler-warnings branch

April 6, 2023 15:25