gh-101819: Remove _PyWindowsConsoleIO_Type from the Windows DLL by erlend-aasland · Pull Request #101904 · python/cpython

Can you remove the Check macro entirely? It's got to go if we're supporting multiple instances of the module, so may as well just go now.

I'd kinda like to see a few more tstate parameters being passed around, but I guess if the lower level APIs don't take them then there's nowhere to pass them 🤷‍♂️

Can you remove the Check macro entirely? It's got to go if we're supporting multiple instances of the module, so may as well just go now.

The one in PC/_testconsole.c, Python/pylifecycle.c, or both? I assume the assert in Modules/_io/winconsoleio.c should stay.

I was thinking the definition in _iomodule.h and anywhere it's used, but I see now that's fully internal anyway.

Provided we're not changing any supported public API, it's fine.

Provided we're not changing any supported public API, it's fine.

AFAICS, _iomodule.h is not included in Python.h, so we should be fine.

Don't worry about waiting for that PR to merge. I don't think it conflicts. Regardless, I don't mind fixing my branch if needed.

Status check is done, and it's a success ✅.

Thanks for the reviews; highly appreciated.