◐ Shell
clean mode source ↗

gh-87092: Make jump target label equal to the offset of the target in the instructions sequence by iritkatriel · Pull Request #102093 · python/cpython

Conversation

@iritkatriel

In the instruction stream exposed by the compiler to Python for testing, the labels are no longer included as explicit entries. Instead, the offset of the target instruction in the stream is used.

This is a step towards the codegen producing an instruction stream instead of basic blocks.

…the instructions sequence

iritkatriel

@iritkatriel

This windows test failure is unrelated.

Note that this PR is only changing test code.

erlend-aasland

iritkatriel

@iritkatriel iritkatriel changed the title gh-87092: Jump target label is now the offset of the target in the instructions sequence gh-87092: Make jump target label equal to the offset of the target in the instructions sequence

Feb 27, 2023

@iritkatriel

markshannon

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is only for testing, I'll trust you that is a worthwhile change.

It looks correct.

carljm added a commit to carljm/cpython that referenced this pull request

Feb 28, 2023

Labels