◐ Shell
clean mode source ↗

gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) by iritkatriel · Pull Request #102193 · python/cpython

@iritkatriel

Skipping news because these are internal-only changes, and the fact of PyErr_Fetch/Restore being obsolete is already in the news.

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 9abebe0 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@iritkatriel iritkatriel changed the title gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (Objects/ and Python/)

Feb 24, 2023

@iritkatriel

There's a refcount issue somewhere. Checking.

erlend-aasland

@erlend-aasland

I must say this is a great improvement in readability. The new API is indeed a better API. Thanks!

@iritkatriel iritkatriel changed the title gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (Objects/ and Python/) gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/)

Feb 24, 2023

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 603922d 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit df86e20 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit f29ca0b 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@iritkatriel

There's only one failure now, in an AMD64 RHEL7 builedbot which has been flaky for a couple of months. I'll call it a pass.

@iritkatriel

There's only one failure now, in an AMD64 RHEL7 builedbot

It passes now, so this PR should be fine.

markshannon

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor edit needed, otherwise LGTM.

@bedevere-bot

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

markshannon

carljm added a commit to carljm/cpython that referenced this pull request

Feb 28, 2023