◐ Shell
clean mode source ↗

GH-63062: Implement __subclasshook__() for Finders and Loaders in abc lib by furkanonder · Pull Request #102763 · python/cpython

bedevere-bot

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@furkanonder

@furkanonder furkanonder commented

Mar 16, 2023

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

@brettcannon

Copy link Copy Markdown

Member

FYI there's a merge conflict.

@brettcannon brettcannon removed their request for review

June 9, 2023 22:29

@brettcannon

Copy link Copy Markdown

Member

To keep my review queue clean, I'm removing myself to review until the merge conflict is fixed. Feel free to add me back once the conflict is fixed.

@furkanonder

Copy link Copy Markdown

Contributor Author

This PR seems to deprecate find_loader and find_module. For this reason I think it makes sense to close the PR. @brettcannon What do you think?

@brettcannon

Copy link Copy Markdown

Member

@furkanonder it's your PR so if you think it should be closed I'm fine with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@furkanonder @brettcannon @bedevere-bot