gh-102939: Fix "conversion from Py_ssize_t to long" warning in builtins by sobolevn · Pull Request #102940 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Conversation
Member
Since we now work with Py_size_t instead of long (see 7559f5f#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1) I've change the PyLong_ constructor.
bedevere-bot
mentioned this pull request
bedevere-bot
added
the
awaiting review
label
sobolevn
added
the
skip news
label
sobolevn
commented
Mar 23, 2023
sobolevn commented
Member Author
Looks like the warning is gone! 🎉
I've opened a new issue about ‘subobj’ may be used uninitialized in this function [-Wmaybe-uninitialized]: #102941
sobolevn
mentioned this pull request
sobolevn
requested a review
from markshannon
sobolevn
mentioned this pull request
markshannon
approved these changes
markshannon
left a comment
markshannon
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
markshannon
merged commit
0f2ba65
into
python:main
bedevere-bot
removed
the
awaiting merge
label
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request
warsaw pushed a commit to warsaw/cpython that referenced this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment